The following document contains the results of PMD 5.0.2.
| Violation | Line |
|---|---|
| Useless parentheses. | 137 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.io.UnsupportedEncodingException' | 3 |
| Avoid unused imports such as 'java.net.URLDecoder' | 4 |
| Violation | Line |
|---|---|
| Useless parentheses. | 62 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'org.apache.struts.util.TokenProcessor' | 8 |
| Avoid unused imports such as 'org.apache.struts.Globals' | 9 |
| Avoid unused imports such as 'org.apache.struts.taglib.html.Constants' | 10 |
| Avoid unused imports such as 'uk.ac.ebi.intenz.domain.constants.EnzymeNameTypeConstant' | 12 |
| Avoid unused imports such as 'uk.ac.ebi.intenz.domain.history.HistoryGraph' | 14 |
| Avoid unused imports such as 'uk.ac.ebi.intenz.domain.reference.Book' | 15 |
| Avoid unused imports such as 'uk.ac.ebi.intenz.domain.reference.Journal' | 16 |
| Avoid unused imports such as 'uk.ac.ebi.intenz.domain.reference.Patent' | 17 |
| Avoid unused imports such as 'uk.ac.ebi.intenz.domain.reference.Reference' | 18 |
| Avoid duplicate imports such as 'uk.ac.ebi.intenz.webapp.utilities.IntEnzUtilities' | 21 |
| Avoid unused imports such as 'java.util.Iterator' | 28 |
| Avoid unused imports such as 'java.util.SortedSet' | 30 |
| Violation | Line |
|---|---|
| These nested if statements could be combined | 71 - 75 |
| Avoid unused method parameters such as 'translate'. | 181 |
| Avoid unused method parameters such as 'translate'. | 241 |
| Avoid unused local variables such as 'iii'. | 247 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'uk.ac.ebi.intenz.domain.enzyme.DataComment' | 20 |
| Avoid unused imports such as 'uk.ac.ebi.rhea.domain.Status' | 32 |
| Avoid unused imports such as 'uk.ac.ebi.intenz.webapp.dtos.DataCommentDTO' | 34 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'uk.ac.ebi.rhea.domain.Status' | 18 |
| Avoid unused method parameters such as 'ec'. | 129 |
| Violation | Line |
|---|---|
| Useless parentheses. | 63 |
| Violation | Line |
|---|---|
| Useless parentheses. | 57 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'uk.ac.ebi.intenz.webapp.utilities.EntryLockSingleton' | 8 |
| Useless parentheses. | 52 |
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'fulltextQueryStatement()'. | 41 |
| Avoid unused private fields such as 'SEARCH_JSP'. | 49 |
| Useless parentheses. | 90 - 91 |
| Useless parentheses. | 90 |
| Avoid returning from a finally block | 147 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'org.apache.struts.Globals' | 5 |
| Avoid unused imports such as 'org.apache.struts.taglib.html.Constants' | 6 |
| Avoid unused imports such as 'uk.ac.ebi.intenz.domain.constants.EnzymeViewConstant' | 8 |
| Avoid unused imports such as 'uk.ac.ebi.intenz.domain.exceptions.DomainException' | 12 |
| Avoid unused imports such as 'uk.ac.ebi.intenz.webapp.utilities.ControlFlowToken' | 15 |
| Avoid unused imports such as 'java.sql.SQLException' | 25 |
| Avoid unused imports such as 'java.util.Map' | 26 |
| Avoid unused private fields such as 'LOGGER'. | 40 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'org.apache.struts.Globals' | 5 |
| Avoid unused imports such as 'org.apache.struts.taglib.html.Constants' | 6 |
| Avoid unused imports such as 'uk.ac.ebi.intenz.domain.constants.EnzymeViewConstant' | 8 |
| Avoid unused imports such as 'uk.ac.ebi.intenz.domain.exceptions.DomainException' | 12 |
| Avoid unused imports such as 'uk.ac.ebi.intenz.webapp.utilities.ControlFlowToken' | 15 |
| Avoid unused imports such as 'java.sql.SQLException' | 25 |
| Avoid unused imports such as 'java.util.Map' | 26 |
| Avoid unused private fields such as 'LOGGER'. | 40 |
| Violation | Line |
|---|---|
| Useless parentheses. | 74 |
| Violation | Line |
|---|---|
| Useless parentheses. | 140 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.util.Map' | 7 |
| Avoid unused imports such as 'java.util.HashMap' | 8 |
| Avoid unused imports such as 'uk.ac.ebi.intenz.domain.enzyme.DataComment' | 10 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.sql.SQLException' | 10 |
| Avoid unused imports such as 'uk.ac.ebi.intenz.domain.exceptions.EcException' | 37 |
| Avoid unused imports such as 'uk.ac.ebi.rhea.mapper.MapperException' | 40 |
| Useless parentheses. | 690 |
| Useless parentheses. | 763 |
| Useless parentheses. | 764 |
| These nested if statements could be combined | 977 - 981 |
| Violation | Line |
|---|---|
| Useless parentheses. | 179 |
| Avoid unused private methods such as 'validateCASRegistryNumber()'. | 283 |
| Avoid empty if statements | 284 - 286 |
| Violation | Line |
|---|---|
| Useless parentheses. | 107 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'org.apache.struts.action.ActionErrors' | 3 |
| Avoid unused imports such as 'org.apache.struts.action.ActionMapping' | 4 |
| Avoid unused imports such as 'javax.servlet.http.HttpServletRequest' | 7 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'org.apache.struts.action.ActionErrors' | 3 |
| Avoid unused imports such as 'org.apache.struts.action.ActionMapping' | 4 |
| Avoid unused imports such as 'javax.servlet.http.HttpServletRequest' | 7 |
| Violation | Line |
|---|---|
| Useless parentheses. | 97 |
| Violation | Line |
|---|---|
| Useless parentheses. | 233 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'org.apache.struts.action.ActionErrors' | 3 |
| Avoid unused imports such as 'org.apache.struts.action.ActionMapping' | 4 |
| Avoid unused imports such as 'javax.servlet.http.HttpServletRequest' | 7 |
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'iii'. | 107 |
| Avoid unused private methods such as 'getLinkHTMLTableRow(EnzymeLinkDTO,boolean)'. | 514 |
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOGGER'. | 21 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'org.apache.log4j.Logger' | 3 |
| Avoid unused imports such as 'uk.ac.ebi.intenz.domain.reference.Book' | 5 |
| Avoid unused imports such as 'uk.ac.ebi.intenz.domain.reference.Journal' | 6 |
| Avoid unused imports such as 'uk.ac.ebi.intenz.domain.reference.Patent' | 7 |
| Avoid unused imports such as 'uk.ac.ebi.intenz.domain.reference.Reference' | 8 |
| Violation | Line |
|---|---|
| Useless parentheses. | 45 |
| Useless parentheses. | 67 |
| Violation | Line |
|---|---|
| Avoid unnecessary temporaries when converting primitives to Strings | 41 |
| Violation | Line |
|---|---|
| Useless parentheses. | 173 |
| Useless parentheses. | 174 |
| Avoid unused private methods such as 'validateCofactors(List,ActionMessages)'. | 248 |
| These nested if statements could be combined | 330 - 334 |
| These nested if statements could be combined | 347 - 351 |
| These nested if statements could be combined | 354 - 357 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'uk.ac.ebi.cdb.webservice.AuthorsList' | 9 |
