The following document contains the results of Checkstyle. 
| Rules | Violations | Severity |
|---|---|---|
JavadocPackage
| 2 | |
| NewlineAtEndOfFile | 0 | |
| Translation | 0 | |
| FileLength | 0 | |
FileTabCharacter
| 36 | |
RegexpSingleline
| 7 | |
| JavadocMethod | 28 | |
| JavadocType | 0 | |
| JavadocVariable | 5 | |
| JavadocStyle | 0 | |
| ConstantName | 0 | |
| LocalFinalVariableName | 0 | |
| LocalVariableName | 0 | |
| MemberName | 0 | |
| MethodName | 0 | |
| PackageName | 0 | |
| ParameterName | 0 | |
| StaticVariableName | 4 | |
| TypeName | 0 | |
| AvoidStarImport | 1 | |
| IllegalImport | 0 | |
| RedundantImport | 1 | |
| UnusedImports | 2 | |
| LineLength | 89 | |
| MethodLength | 2 | |
| ParameterNumber | 0 | |
| EmptyForIteratorPad | 1 | |
| MethodParamPad | 9 | |
| NoWhitespaceAfter | 0 | |
| NoWhitespaceBefore | 0 | |
| OperatorWrap | 2 | |
| ParenPad | 55 | |
| TypecastParenPad | 0 | |
| WhitespaceAfter | 0 | |
| WhitespaceAround | 17 | |
| ModifierOrder | 0 | |
| RedundantModifier | 0 | |
| AvoidNestedBlocks | 0 | |
| EmptyBlock | 0 | |
| LeftCurly | 0 | |
| NeedBraces | 13 | |
| RightCurly | 0 | |
| AvoidInlineConditionals | 3 | |
| EmptyStatement | 0 | |
| EqualsHashCode | 0 | |
| HiddenField | 0 | |
| IllegalInstantiation | 0 | |
| InnerAssignment | 0 | |
| MagicNumber | 39 | |
| MissingSwitchDefault | 0 | |
| RedundantThrows | 0 | |
| SimplifyBooleanExpression | 0 | |
| SimplifyBooleanReturn | 0 | |
| DesignForExtension | 0 | |
| FinalClass | 3 | |
| HideUtilityClassConstructor | 4 | |
| InterfaceIsType | 0 | |
| VisibilityModifier | 0 | |
| ArrayTypeStyle | 0 | |
| FinalParameters | 35 | |
| TodoComment | 0 | |
| UpperEll | 0 |
| Violation | Message | Line |
|---|---|---|
| Missing package-info.java file. | 0 | |
| Unused import - uk.ac.ebi.intenz.domain.enzyme.EnzymeCommissionNumber. | 5 | |
| Unused import - uk.ac.ebi.rhea.domain.Status. | 6 | |
| Using the '.*' form of import should be avoided - java.sql.*. | 9 | |
| Line is longer than 80 characters (found 120). | 16 | |
| Utility classes should not have a public or default constructor. | 21 | |
| Line contains a tab character. | 23 | |
| Missing a Javadoc comment. | 23 | |
| Line has trailing spaces. | 24 | |
| Line contains a tab character. | 24 | |
| Missing a Javadoc comment. | 25 | |
| Line is longer than 80 characters (found 88). | 26 | |
| Line contains a tab character. | 27 | |
| Missing a Javadoc comment. | 35 | |
| Name 'DELETE_ALL' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 35 | |
| Missing a Javadoc comment. | 37 | |
| Line is longer than 80 characters (found 89). | 38 | |
| Line contains a tab character. | 45 | |
| Parameter args should be final. | 47 | |
| '{' is not preceded with whitespace. | 49 | |
| Line is longer than 80 characters (found 82). | 59 | |
| '{' is not preceded with whitespace. | 63 | |
| '3' is a magic number. | 65 | |
| '{' is not preceded with whitespace. | 69 | |
| '4' is a magic number. | 71 | |
| Line contains a tab character. | 76 | |
| 'if' construct must use '{}'s. | 83 | |
| 'if' construct must use '{}'s. | 84 | |
| '5' is a magic number. | 88 | |
| Line contains a tab character. | 103 | |
| Line contains a tab character. | 106 | |
| Line contains a tab character. | 107 | |
| Line contains a tab character. | 108 | |
| '?' is not preceded with whitespace. | 108 | |
| Avoid inline conditionals. | 108 | |
| Line contains a tab character. | 109 | |
| Line contains a tab character. | 110 | |
| Line contains a tab character. | 113 | |
| '3' is a magic number. | 114 | |
| '4' is a magic number. | 115 | |
| 'if' construct must use '{}'s. | 130 | |
| 'if' construct must use '{}'s. | 131 |
| Violation | Message | Line |
|---|---|---|
| Utility classes should not have a public or default constructor. | 40 | |
| Line contains a tab character. | 42 | |
| Missing a Javadoc comment. | 42 | |
| Line has trailing spaces. | 43 | |
| Line contains a tab character. | 43 | |
| Name 'FIND_ALL' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 51 | |
| Line contains a tab character. | 52 | |
| Line contains a tab character. | 53 | |
| Line contains a tab character. | 54 | |
| Line is longer than 80 characters (found 84). | 55 | |
| Line contains a tab character. | 55 | |
| Line contains a tab character. | 56 | |
| Line contains a tab character. | 57 | |
| Line contains a tab character. | 58 | |
| Line contains a tab character. | 59 | |
| Line contains a tab character. | 60 | |
| Missing a Javadoc comment. | 62 | |
| Name 'DELETE_ALL' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 62 | |
| Missing a Javadoc comment. | 64 | |
| Name 'INSERT' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 64 | |
| Line contains a tab character. | 65 | |
| Line contains a tab character. | 66 | |
| Line contains a tab character. | 67 | |
| Line contains a tab character. | 68 | |
| Line has trailing spaces. | 69 | |
| Line has trailing spaces. | 70 | |
| Line has trailing spaces. | 73 | |
| Method length is 230 lines (max allowed is 150). | 75 | |
| Parameter args should be final. | 75 | |
| '{' is not preceded with whitespace. | 78 | |
| '{' is not preceded with whitespace. | 92 | |
| '3' is a magic number. | 94 | |
| Line is longer than 80 characters (found 89). | 102 | |
| '4' is a magic number. | 106 | |
| Line is longer than 80 characters (found 82). | 116 | |
| 'if' construct must use '{}'s. | 118 | |
| 'if' construct must use '{}'s. | 119 | |
| '5' is a magic number. | 123 | |
| Line contains a tab character. | 127 | |
| Line is longer than 80 characters (found 84). | 132 | |
| Line is longer than 80 characters (found 117). | 155 | |
| Line is longer than 80 characters (found 95). | 161 | |
| 'if' construct must use '{}'s. | 162 | |
| Line is longer than 80 characters (found 90). | 162 | |
| 'if' is not followed by whitespace. | 162 | |
| '3' is a magic number. | 163 | |
| '4' is a magic number. | 164 | |
| '5' is a magic number. | 165 | |
| '6' is a magic number. | 166 | |
| '7' is a magic number. | 167 | |
| Line is longer than 80 characters (found 83). | 179 | |
| Line is longer than 80 characters (found 87). | 183 | |
| Line is longer than 80 characters (found 105). | 190 | |
| '3' is a magic number. | 196 | |
| '4' is a magic number. | 197 | |
| '5' is a magic number. | 198 | |
| '6' is a magic number. | 199 | |
| '7' is a magic number. | 200 | |
| Line is longer than 80 characters (found 82). | 213 | |
| Line is longer than 80 characters (found 83). | 220 | |
| Line is longer than 80 characters (found 111). | 221 | |
| '3' is a magic number. | 227 | |
| '4' is a magic number. | 228 | |
| '5' is a magic number. | 229 | |
| '6' is a magic number. | 230 | |
| '7' is a magic number. | 231 | |
| Line is longer than 80 characters (found 90). | 244 | |
| '3' is a magic number. | 250 | |
| Line is longer than 80 characters (found 97). | 252 | |
| Line is longer than 80 characters (found 117). | 253 | |
| '3' is a magic number. | 259 | |
| '4' is a magic number. | 260 | |
| '5' is a magic number. | 261 | |
| '6' is a magic number. | 262 | |
| '7' is a magic number. | 263 | |
| 'if' construct must use '{}'s. | 285 | |
| 'if' construct must use '{}'s. | 286 | |
| 'if' construct must use '{}'s. | 287 | |
| '1000' is a magic number. | 302 | |
| Missing a Javadoc comment. | 306 | |
| Parameter xml should be final. | 306 | |
| '4000' is a magic number. | 309 | |
| '4000' is a magic number. | 310 | |
| '4000' is a magic number. | 311 | |
| Missing a Javadoc comment. | 318 | |
| Parameter seconds should be final. | 318 | |
| '3599' is a magic number. | 321 | |
| '3600' is a magic number. | 322 | |
| '3600' is a magic number. | 324 | |
| '59' is a magic number. | 326 | |
| '60' is a magic number. | 327 | |
| '60' is a magic number. | 329 |
| Violation | Message | Line |
|---|---|---|
| Missing package-info.java file. | 0 | |
| Class EnzymeClassHelper should be declared as final. | 13 | |
| Line is longer than 80 characters (found 83). | 15 | |
| Missing a Javadoc comment. | 17 | |
| '{' is not followed by whitespace. | 17 | |
| '}' is not preceded with whitespace. | 17 | |
| Line is longer than 80 characters (found 83). | 19 | |
| Missing a Javadoc comment. | 19 | |
| Parameter enzymeClass should be final. | 19 | |
| Parameter encoding should be final. | 19 | |
| Line is longer than 80 characters (found 92). | 33 | |
| Line is longer than 80 characters (found 121). | 39 | |
| Line is longer than 80 characters (found 99). | 44 | |
| Line is longer than 80 characters (found 128). | 50 | |
| Missing a Javadoc comment. | 114 | |
| Parameter text should be final. | 114 |
| Violation | Message | Line |
|---|---|---|
| Utility classes should not have a public or default constructor. | 25 | |
| Line is longer than 80 characters (found 108). | 27 | |
| Missing a Javadoc comment. | 27 | |
| '(' is preceded with whitespace. | 27 | |
| Parameter enzymeEntry should be final. | 27 | |
| Parameter encoding should be final. | 27 | |
| Parameter view should be final. | 27 | |
| Parameter intenzTextXML should be final. | 28 | |
| Line is longer than 80 characters (found 111). | 29 | |
| '(' is followed by whitespace. | 29 | |
| ')' is preceded with whitespace. | 29 | |
| '?' should be on a new line. | 30 | |
| Avoid inline conditionals. | 30 | |
| Line is longer than 80 characters (found 81). | 31 | |
| Line contains a tab character. | 31 | |
| '?' should be on a new line. | 33 | |
| Avoid inline conditionals. | 33 | |
| Line contains a tab character. | 34 | |
| Line is longer than 80 characters (found 108). | 38 | |
| Missing a Javadoc comment. | 38 | |
| '(' is preceded with whitespace. | 38 | |
| Parameter enzymeEntry should be final. | 38 | |
| Parameter encoding should be final. | 38 | |
| 'if' construct must use '{}'s. | 49 | |
| '(' is followed by whitespace. | 49 | |
| ')' is preceded with whitespace. | 49 | |
| '(' is followed by whitespace. | 51 | |
| ')' is preceded with whitespace. | 51 | |
| '(' is followed by whitespace. | 53 | |
| ')' is preceded with whitespace. | 53 | |
| Line is longer than 80 characters (found 106). | 59 | |
| Line is longer than 80 characters (found 122). | 63 | |
| Line is longer than 80 characters (found 95). | 67 | |
| Line is longer than 80 characters (found 89). | 69 | |
| 'if' construct must use '{}'s. | 70 | |
| Line is longer than 80 characters (found 107). | 70 | |
| '(' is followed by whitespace. | 70 | |
| ')' is preceded with whitespace. | 70 | |
| Line is longer than 80 characters (found 81). | 72 | |
| Line is longer than 80 characters (found 110). | 75 | |
| Line is longer than 80 characters (found 81). | 138 | |
| Line is longer than 80 characters (found 99). | 146 | |
| Method length is 219 lines (max allowed is 150). | 146 | |
| Missing a Javadoc comment. | 146 | |
| '(' is preceded with whitespace. | 146 | |
| Parameter enzymeEntry should be final. | 146 | |
| Parameter encoding should be final. | 146 | |
| Parameter view should be final. | 147 | |
| Line is longer than 80 characters (found 95). | 164 | |
| 'if' construct must use '{}'s. | 167 | |
| Line is longer than 80 characters (found 107). | 167 | |
| '(' is followed by whitespace. | 167 | |
| ')' is preceded with whitespace. | 167 | |
| Line is longer than 80 characters (found 81). | 169 | |
| Line is longer than 80 characters (found 110). | 172 | |
| '(' is followed by whitespace. | 181 | |
| ')' is preceded with whitespace. | 181 | |
| '(' is followed by whitespace. | 182 | |
| ')' is preceded with whitespace. | 182 | |
| Line contains a tab character. | 184 | |
| Line contains a tab character. | 185 | |
| '{' is not preceded with whitespace. | 185 | |
| Line contains a tab character. | 186 | |
| Line contains a tab character. | 187 | |
| Line is longer than 80 characters (found 105). | 194 | |
| '{' is not preceded with whitespace. | 196 | |
| '(' is followed by whitespace. | 205 | |
| ')' is preceded with whitespace. | 205 | |
| '(' is followed by whitespace. | 208 | |
| ')' is preceded with whitespace. | 208 | |
| Line is longer than 80 characters (found 122). | 210 | |
| Line contains a tab character. | 210 | |
| Line is longer than 80 characters (found 86). | 212 | |
| Line is longer than 80 characters (found 98). | 216 | |
| '{' is not preceded with whitespace. | 224 | |
| Line is longer than 80 characters (found 115). | 225 | |
| '{' is not preceded with whitespace. | 229 | |
| Line is longer than 80 characters (found 110). | 232 | |
| '(' is followed by whitespace. | 238 | |
| ')' is preceded with whitespace. | 238 | |
| '(' is followed by whitespace. | 239 | |
| ')' is preceded with whitespace. | 239 | |
| Line is longer than 80 characters (found 94). | 242 | |
| '(' is followed by whitespace. | 243 | |
| ')' is preceded with whitespace. | 243 | |
| '(' is followed by whitespace. | 247 | |
| ')' is preceded with whitespace. | 247 | |
| '(' is followed by whitespace. | 251 | |
| ')' is preceded with whitespace. | 251 | |
| Line is longer than 80 characters (found 106). | 258 | |
| '(' is followed by whitespace. | 259 | |
| ')' is preceded with whitespace. | 259 | |
| '(' is followed by whitespace. | 263 | |
| ')' is preceded with whitespace. | 263 | |
| '(' is followed by whitespace. | 267 | |
| ')' is preceded with whitespace. | 267 | |
| '(' is followed by whitespace. | 280 | |
| ')' is preceded with whitespace. | 280 | |
| '(' is followed by whitespace. | 281 | |
| ')' is preceded with whitespace. | 281 | |
| '(' is followed by whitespace. | 283 | |
| ')' is preceded with whitespace. | 283 | |
| Line is longer than 80 characters (found 104). | 285 | |
| Line is longer than 80 characters (found 116). | 289 | |
| '(' is followed by whitespace. | 298 | |
| ')' is preceded with whitespace. | 298 | |
| '(' is followed by whitespace. | 299 | |
| ';' is followed by whitespace. | 299 | |
| Line is longer than 80 characters (found 82). | 300 | |
| Line contains a tab character. | 300 | |
| '(' is followed by whitespace. | 315 | |
| ')' is preceded with whitespace. | 315 | |
| Line is longer than 80 characters (found 106). | 319 | |
| '(' is followed by whitespace. | 322 | |
| ')' is preceded with whitespace. | 322 | |
| Line is longer than 80 characters (found 98). | 359 | |
| Missing a Javadoc comment. | 367 | |
| '(' is preceded with whitespace. | 367 | |
| Parameter text should be final. | 367 |
| Violation | Message | Line |
|---|---|---|
| Redundant import from the same package - uk.ac.ebi.intenz.tools.release.helper.EnzymeEntryHelper. | 8 | |
| Utility classes should not have a public or default constructor. | 27 | |
| Line has trailing spaces. | 32 | |
| Expected an @return tag. | 38 | |
| Line is longer than 80 characters (found 112). | 38 | |
| '(' is preceded with whitespace. | 38 | |
| Parameter reference should be final. | 38 | |
| Expected @param tag for 'reference'. | 38 | |
| Parameter number should be final. | 38 | |
| Expected @param tag for 'number'. | 38 | |
| Parameter encoding should be final. | 38 | |
| Expected @param tag for 'encoding'. | 38 | |
| '(' is followed by whitespace. | 41 | |
| ')' is preceded with whitespace. | 41 | |
| '(' is followed by whitespace. | 44 | |
| ')' is preceded with whitespace. | 44 | |
| '(' is followed by whitespace. | 47 | |
| ')' is preceded with whitespace. | 47 | |
| Expected an @return tag. | 63 | |
| Line is longer than 80 characters (found 101). | 63 | |
| '(' is preceded with whitespace. | 63 | |
| Parameter reference should be final. | 63 | |
| Expected @param tag for 'reference'. | 63 | |
| Parameter number should be final. | 63 | |
| Expected @param tag for 'number'. | 63 | |
| Parameter encoding should be final. | 63 | |
| Expected @param tag for 'encoding'. | 63 | |
| Line is longer than 80 characters (found 111). | 70 | |
| Line is longer than 80 characters (found 95). | 72 | |
| Line is longer than 80 characters (found 105). | 75 | |
| Line is longer than 80 characters (found 109). | 79 | |
| Line is longer than 80 characters (found 93). | 81 | |
| Line is longer than 80 characters (found 138). | 83 | |
| Missing a Javadoc comment. | 93 | |
| '(' is preceded with whitespace. | 93 | |
| Parameter book should be final. | 93 | |
| Parameter encoding should be final. | 93 | |
| Line is longer than 80 characters (found 111). | 107 | |
| Line is longer than 80 characters (found 95). | 109 | |
| Line is longer than 80 characters (found 105). | 112 | |
| Line is longer than 80 characters (found 110). | 116 | |
| Line is longer than 80 characters (found 94). | 118 | |
| Line is longer than 80 characters (found 104). | 121 | |
| Line is longer than 80 characters (found 113). | 128 | |
| Line is longer than 80 characters (found 102). | 130 | |
| Line is longer than 80 characters (found 107). | 133 | |
| Line is longer than 80 characters (found 108). | 137 | |
| Line is longer than 80 characters (found 97). | 139 | |
| Line is longer than 80 characters (found 137). | 141 | |
| Line is longer than 80 characters (found 83). | 152 | |
| Missing a Javadoc comment. | 152 | |
| '(' is preceded with whitespace. | 152 | |
| Parameter journal should be final. | 152 | |
| Parameter encoding should be final. | 152 | |
| Missing a Javadoc comment. | 184 | |
| '(' is preceded with whitespace. | 184 | |
| Parameter patent should be final. | 184 | |
| Parameter encoding should be final. | 184 |
| Violation | Message | Line |
|---|---|---|
| Class EnzymeSubSubclassHelper should be declared as final. | 13 | |
| Line is longer than 80 characters (found 83). | 15 | |
| Missing a Javadoc comment. | 17 | |
| '{' is not followed by whitespace. | 17 | |
| '}' is not preceded with whitespace. | 17 | |
| Line has trailing spaces. | 18 | |
| Line is longer than 80 characters (found 95). | 19 | |
| Missing a Javadoc comment. | 19 | |
| Parameter enzymeSubSubclass should be final. | 19 | |
| Parameter encoding should be final. | 19 | |
| Line is longer than 80 characters (found 98). | 33 | |
| Line is longer than 80 characters (found 127). | 39 | |
| Line is longer than 80 characters (found 105). | 45 | |
| Line is longer than 80 characters (found 134). | 51 | |
| Missing a Javadoc comment. | 115 | |
| Parameter text should be final. | 115 |
| Violation | Message | Line |
|---|---|---|
| Class EnzymeSubclassHelper should be declared as final. | 13 | |
| Line is longer than 80 characters (found 83). | 15 | |
| Missing a Javadoc comment. | 17 | |
| '{' is not followed by whitespace. | 17 | |
| '}' is not preceded with whitespace. | 17 | |
| Line is longer than 80 characters (found 89). | 19 | |
| Missing a Javadoc comment. | 19 | |
| Parameter enzymeSubclass should be final. | 19 | |
| Parameter encoding should be final. | 19 | |
| Line is longer than 80 characters (found 95). | 33 | |
| Line is longer than 80 characters (found 124). | 39 | |
| Line is longer than 80 characters (found 102). | 45 | |
| Line is longer than 80 characters (found 131). | 51 | |
| Missing a Javadoc comment. | 115 | |
| Parameter text should be final. | 115 |